fix: correct baseUrl and URL fallbacks for GitHub Pages deployment#3
Merged
Conversation
Site is served at https://arubacloud.github.io/api/ so: - url fallback: 'https://arubacloud.github.io' - baseUrl fallback: '/api/' Both docusaurus.config.js and deploy.yml now use the correct defaults when SITE_URL / BASE_URL repository variables are not explicitly set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The GitHub Pages site at https://arubacloud.github.io/api/ was loading with a broken layout because the
baseUrlwas set to/instead of/api/.Root cause
The
SITE_URLandBASE_URLGitHub repository variables were not set, so the build fell back to the hardcoded defaults (baseUrl: '/'). Since previous builds were failing at the SSG stage, this was never visible — now that the build passes, the wrong baseUrl is deployed.Changes
docusaurus.config.js: updated fallbackurltohttps://arubacloud.github.ioandbaseUrlto/api/.github/workflows/deploy.yml: same correct defaults in the build step env varsTesting
enanditlocales ✅